-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment Status Command Does Not Respect -namespace Wildcard #16792
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0da9033
func: add namespace support for list deployment
Juanadelacuesta 7ee10ee
func: add wildcard to namespace filter for deployments
Juanadelacuesta 4403656
Update deployment_endpoint.go
Juanadelacuesta 78ba537
style: use must instead of require or asseert
Juanadelacuesta e87ddbe
style: rename paginator to avoid clash with import
Juanadelacuesta f6e1ecd
style: add changelog entry
Juanadelacuesta 25e4c7c
fix: add missing parameter for upsert jobs
Juanadelacuesta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:bug | ||
core: the deployment's list endpoint now supports look up by prefix using the wildcard for namespace | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking but something we might want to get agreement on with the team and then document in our RPC checklist...
There's a small inconsistency here between the behavior of the first permissions check (on line 458) and this permissions check in the blocking query:
ErrPermissionDenied
I spot-checked some of the other
List
RPCs and it looks like we're inconsistent with this across the code base; some RPCs have both checks (ex.Eval.List
,Job.List
) while others only have the second check (ex.Namespaces.ListNamespace
,Variables.List
).