Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul/connect: fixed a bug where restarting proxy tasks failed. #16815

Merged
merged 2 commits into from
Apr 11, 2023
Merged

consul/connect: fixed a bug where restarting proxy tasks failed. #16815

merged 2 commits into from
Apr 11, 2023

Commits on Apr 11, 2023

  1. consul/connect: fixed a bug where restarting proxy tasks failed. 

    The first start of a Consul Connect proxy sidecar triggers a run
of the envoy_version hook which modifies the task config image
entry. The modification takes into account a number of factors to
correctly populate this. Importantly, once the hook has run, it
marks itself as done so the taskrunner will not execute it again.

When the client receives a non-destructive update for the
allocation which the proxy sidecar is a member of, it will update
and overwrite the task definition within the taskerunner. In doing
so it overwrite the modification performed by the hook. If the
allocation is restarted, the envoy_version hook will be skipped as
it previously marked itself as done, and therefore the sidecar
config image is incorrect and causes a driver error.

The fix removes the hook in marking itself as done to the view of
the taskrunner.
    @jrasell
    jrasell committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    23c6c94 View commit details
    Browse the repository at this point in the history

  2. changelog: add entry for #16815

    @jrasell
    jrasell committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    11dc5e3 View commit details
    Browse the repository at this point in the history