e2e: add e2e tests for job submission api #16841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
approved these changes
Apr 11, 2023
e2e/e2eutil/allocs.go
Outdated
| @@ -65,11 +69,38 @@ func WaitForAllocStatusComparison(query func() ([]string, error), comparison fun | |||
| return err | |||
| } | |||
|
|
|||
| // SingleAllocID returns the ID for the first allocation found for jobID in namespace | |||
| // at the specified job version number. Will retry for a ten seconds before returning | |||
There was a problem hiding this comment.
Suggested change
| // at the specified job version number. Will retry for a ten seconds before returning | |
| // at the specified job version number. Will retry for ten seconds before returning |
| variable "Z" { | ||
| type = bool | ||
| } | ||
|
|
There was a problem hiding this comment.
Not sure if it's relevant as a test case here, but there's also a shorter version for declaring variables:
variables {
A = "B"
}There was a problem hiding this comment.
Yeah these kinds of variables that have the value set directly in the original job are "invisible", at least not without doing some work with the hcl parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds e2e tests around the new job submissions api, added in #16763
No backport, feature is in 1.6