Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drainer: fix codec race condition in integration test #16845

Merged
merged 1 commit into from
Apr 11, 2023

Commits on Apr 11, 2023

  1. drainer: fix codec race condition in integration test

    msgpackrpc codec handles are specific to a connection and cannot be shared
    between goroutines; this can cause corrupted decoding. Fix the drainer
    integration test so that we create separate codecs for the goroutines that the
    test helper spins up to simulate client updates.
    
    This changeset also refactors the drainer integration test to bring it up to
    current idioms and library usages, make assertions more clear, and reduce
    duplication.
    tgross committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    223da17 View commit details
    Browse the repository at this point in the history