Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of drain: use client status to determine drain is complete into release/1.4.x #16879

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Backport of drain: use client status to determine drain is complete into release/1.4.x #16879

merged 1 commit into from
Apr 13, 2023

Commits on Apr 13, 2023

  1. drain: use client status to determine drain is complete (#14348) 

    If an allocation is slow to stop because of `kill_timeout` or `shutdown_delay`,
the node drain is marked as complete prematurely, even though drain monitoring
will continue to report allocation migrations. This impacts the UI or API
clients that monitor node draining to shut down nodes.

This changeset updates the behavior to wait until the client status of all
drained allocs are terminal before marking the node as done draining.
    @tgross
    tgross committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    c620d97 View commit details
    Browse the repository at this point in the history