Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allocrunner: prevent panic on network manager #16921

Merged
merged 3 commits into from
Apr 18, 2023
Merged

allocrunner: prevent panic on network manager #16921

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5c1b6c
allocrunner: prevent panic on network manager
lgfa29 Apr 18, 2023
e4d69fc
changelog: add entry for #16921
lgfa29 Apr 18, 2023
9d700eb
add test case for network manager panic
lgfa29 Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/16921.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
client: Prevent a panic when starting jobs without task group network
```
2 changes: 1 addition & 1 deletion client/allocrunner/network_manager_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func newNetworkManager(alloc *structs.Allocation, driverManager drivermanager.Ma

nm = netManager
networkInitiator = task.Name
} else if tg.Networks[0].Hostname != "" {
} else if len(tg.Networks) > 0 && tg.Networks[0].Hostname != "" {
// TODO jrasell: remove once the default linux network manager
// supports setting the hostname in bridged mode. This currently
// indicates only Docker supports this, which is true unless a
Expand Down