-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC encryption #1705
RPC encryption #1705
Conversation
af3c3b7
to
45b5b14
Compare
@Gerrrr Thanks! Is this PR ready for review? I see that you have been pushing commits after opening the PR, please let me know when it is ready for review. |
Hi @diptanu, Yes, this PR is ready for review now. |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Following the discussion at #469, this PR enables RPC encryption.
Most of the code is taken from Consul codebase.
New general options:
verify_incoming
verify_outgoing
ca_file
cert_file
key_file
domain
Example configuration:
server.hcl
server01.hcl
server02.hcl
server03.hcl
Issues
I am not sure about the
domain
option since it is not used anywhere but during certificate verification. If you have an idea for a certificate hostname format, I am happy to removedomain
and change it accordingly.