Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC encryption #1705

Closed
wants to merge 9 commits into from
Closed

Conversation

Gerrrr
Copy link
Contributor

@Gerrrr Gerrrr commented Sep 13, 2016

Following the discussion at #469, this PR enables RPC encryption.
Most of the code is taken from Consul codebase.

New general options:

  • verify_incoming
  • verify_outgoing
  • ca_file
  • cert_file
  • key_file
  • domain

Example configuration:

server.hcl

verify_incoming = true
verify_outgoing = true

ca_file = "/opt/gopath/src/github.com/hashicorp/nomad/config/certs/root/ca.cert"
cert_file = "/opt/gopath/src/github.com/hashicorp/nomad/config/certs/server.global.nomad/server.cert"
key_file = "/opt/gopath/src/github.com/hashicorp/nomad/config/certs/server.global.nomad/server.key"

data_dir = "/var/lib/nomad"
server {
    enabled = true
    bootstrap_expect = 3
    start_join = ["172.28.128.3", "172.28.128.4", "172.28.128.5"]
}

server01.hcl

bind_addr = "172.28.128.3"

server02.hcl

bind_addr = "172.28.128.4"

server03.hcl

bind_addr = "172.28.128.5"

Issues
I am not sure about the domain option since it is not used anywhere but during certificate verification. If you have an idea for a certificate hostname format, I am happy to remove domain and change it accordingly.

@Gerrrr Gerrrr changed the title RPC encryption [WIP] RPC encryption Sep 13, 2016
@Gerrrr Gerrrr changed the title [WIP] RPC encryption RPC encryption Sep 14, 2016
@diptanu
Copy link
Contributor

diptanu commented Sep 14, 2016

@Gerrrr Thanks! Is this PR ready for review? I see that you have been pushing commits after opening the PR, please let me know when it is ready for review.

@Gerrrr
Copy link
Contributor Author

Gerrrr commented Sep 15, 2016

Hi @diptanu,

Yes, this PR is ready for review now.

@dadgar
Copy link
Contributor

dadgar commented Oct 25, 2016

Thanks @Gerrrr. Closing in favor of #1853

@dadgar dadgar closed this Oct 25, 2016
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants