Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log adding of servers at INFO level #1709

Merged
merged 1 commit into from
Sep 14, 2016
Merged

Conversation

neumayer
Copy link

I'm definitely not getting the whole picture here, but for me it would certainly help just to see this in the logs.

@schmichael
Copy link
Member

I was just working in this code while investigating #1641 -- any chance you could hop into https://gitter.im/hashicorp-nomad/Lobby someday between 9am-5pm PDT and let me know what you're diagnosing?

@schmichael schmichael merged commit 0ba284a into hashicorp:master Sep 14, 2016
@schmichael
Copy link
Member

This code will most likely change before 0.5, but I'll make sure to maintain an INFO log level for this information.

Thanks!

@neumayer
Copy link
Author

I was looking at this and then I realised that I had the same "issue," just that there's no confirmation of having auto discovered other instances. So the confirmation in the logs (when on info level) was to not find errors.

#1692

I do think that this issue can be closed by just having some kind of confirmation that the bootstrapping worked in the logs (at info level).

I'll try to take a look at the issue you linked and tell you if I have anything to say about it :-)

@schmichael
Copy link
Member

@neumayer Oh fantastic. I'm new on the nomad team and missed #1692 -- definitely related to what I'm working on. I'll make sure it gets closed.

Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants