Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: ignore restart issued to terminal allocations #17175

Merged
merged 3 commits into from
May 16, 2023
Merged

client: ignore restart issued to terminal allocations #17175

merged 3 commits into from
May 16, 2023

Commits on May 15, 2023

  1. client: ignore restart issued to terminal allocations 

    This PR fixes a bug where issuing a restart to a terminal allocation
would cause the allocation to run its hooks anyway. This was particularly
apparent with group_service_hook who would then register services but
then never deregister them - as the allocation would be effectively in
a "zombie" state where it is prepped to run tasks but never will.

Fixes #17079
Fixes #16238
Fixes #14618
    @shoenig
    shoenig committed May 15, 2023
    Configuration menu
    Copy the full SHA
    4d86fbe View commit details
    Browse the repository at this point in the history

  2. e2e: add e2e test for alloc restart zombies

    @shoenig
    shoenig committed May 15, 2023
    Configuration menu
    Copy the full SHA
    509a6bf View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. cl: tweak text 

    Co-authored-by: Tim Gross <tgross@hashicorp.com>
    @shoenig @tgross
    shoenig and tgross committed May 16, 2023
    Configuration menu
    Copy the full SHA
    499c285 View commit details
    Browse the repository at this point in the history