Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: prevent -Inf in spread scoring #17198

Merged
merged 1 commit into from
May 16, 2023
Merged

scheduler: prevent -Inf in spread scoring #17198

merged 1 commit into from
May 16, 2023

Commits on May 15, 2023

  1. scheduler: prevent -Inf in spread scoring

    When spread targets have a percent value of zero it's possible for them to
    return -Inf scoring because of a float divide by zero. This is very hard for
    operators to debug because the string "-Inf" is returned in the API and that
    breaks the presentation of debugging data.
    
    Most scoring iterators are bracketed to -1/+1, but spread iterators do not so
    that they can handle greatly unbalanced scoring so we can't simply return a -1
    score without generating a score that might be greater than the negative scores
    set by other spread targets. Instead, track the lowest-seen spread boost and use
    that as the spread boost for any cases where we'd divide by zero.
    
    Fixes: #8863
    tgross committed May 15, 2023
    Configuration menu
    Copy the full SHA
    f9c64e0 View commit details
    Browse the repository at this point in the history