Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of build: move GitHub actions to versions allowed by prodsec into release/1.5.x #17252

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #17238 to be assessed for backporting due to the inclusion of the label backport/1.5.x.

The below text is copied from the body of the original PR.


The backspace/ember-asset-size action we're using is unmaintained and has a bunch of vulns in it, so it won't pass security screening (this is a NodeJS action so it has piles of dependencies, 99% of which won't be in use but fails automated screening anyways). Move this to the upstream version.

The machine-learning-apps/pr-comment action also presents a problem for the ProdSec security screening because it's archived and also runs an external Docker image. Move this to a likely-ok maintained action for now, until we can spare some time to remove this in lieu of something more reasonable that isn't a GitHub action.

Once this is tested, I'll then have to follow up in https://github.com/hashicorp/security-tsccr/pull/428 to pin the SHA, and then I'll have to follow-up once that other PR is merged to pin the SHAs here.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/gha-actions-shuffle/entirely-helped-mammoth branch from 2f95db0 to e82d242 Compare May 19, 2023 14:19
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit f55a7a9 into release/1.5.x May 19, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/gha-actions-shuffle/entirely-helped-mammoth branch May 19, 2023 14:19
@github-actions
Copy link

Ember Test Audit comparison

release/1.5.x e82d242 change
passes 1489 1489 0
failures 0 0 0
flaky 0 0 0
duration 12m 12s 683ms 11m 31s 777ms -40s 906ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants