Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post 1.5.6 release #17276

Merged
merged 4 commits into from
May 22, 2023
Merged

post 1.5.6 release #17276

merged 4 commits into from
May 22, 2023

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented May 22, 2023

  • Generate files for 1.5.6 release
  • Prepare for next release
  • Merge release 1.5.6 files

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philrenaud and @angrycub recently did a one-off commit of a new version of the bindata_assetfs.go from a build from main b/c the old one was super-broken with the current main API (ref #17263). Let's remove this file from this PR so that we don't overwrite that.

@shoenig
Copy link
Member Author

shoenig commented May 22, 2023

Added another commit reverting the change to bindata_ssetfs; not sure I want to muck with redoing the steps to generate the branch

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants