Refactor task validation #17344
Merged
Refactor task validation #17344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juanadelacuesta
approved these changes
May 30, 2023
Move all validations related to task fields to Task.Validate(). Prior to this, some task validations were being done inside TaskGroup.Validate() because they required access to some group values. But similarly to how TaskGroup.Validate() tasks the job as parameter, it's fair to expect the task to receive its group.
lgfa29
force-pushed
the
refact-task-validation
branch
from
a5f3e0d
to
0c80deb
Compare
|
After looking at it again I thought it would be best to merge and backport #17342 and only merge this refactoring to I think it's a fairly stable part of the code that is not expected to receive backports (famous last words 😅) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all validations related to task fields to
Task.Validate(). Prior to this, some task validations were being done insideTaskGroup.Validate()because they required access to some group values.But similarly to how
TaskGroup.Validate()takes the job as parameter, it's fair to expect the task to receive its group.Note: this could be considered an alternative implementation for #17342, but we could also just merge a5f3e0d, or nothing at all if we don't think this is worth it 😄