-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry all servers on RPC call failure #1735
Merged
Merged
Commits on Sep 23, 2016
-
Retry all servers on RPC call failure
rpcproxy is refactored into serverlist which prioritizes good servers over servers in a remote DC or who have had a failure. Registration, heartbeating, and alloc status updating will retry faster when new servers are discovered. Consul discovery will be retried more quickly when no servers are available (eg on startup or an outage).
Configuration menu - View commit details
-
Copy full SHA for 64ac9b9 - Browse repository at this point
Copy the full SHA 64ac9b9View commit details
Commits on Sep 24, 2016
-
Replace periodic handlers with event driven disco
Remove use of periodic consul handlers in the client and just use goroutines. Consul Discovery is now triggered with a chan instead of using a timer and deadline to trigger. Once discovery is complete a chan is ticked so all goroutines waiting for servers will run. Should speed up bootstraping and recovery while decreasing spinning on timers.
Configuration menu - View commit details
-
Copy full SHA for 6d9670e - Browse repository at this point
Copy the full SHA 6d9670eView commit details
Commits on Sep 26, 2016
-
Test asserted endpoint appendend servers, but the new/desired behavior is for the endpoint to set/overwrite servers.
Configuration menu - View commit details
-
Copy full SHA for 6b9be92 - Browse repository at this point
Copy the full SHA 6b9be92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01ff307 - Browse repository at this point
Copy the full SHA 01ff307View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bac143 - Browse repository at this point
Copy the full SHA 3bac143View commit details -
doDisco -> triggerDiscoveryCh; discovered -> serversDiscoveredCh
Also fix log line formatting
Configuration menu - View commit details
-
Copy full SHA for a35fb33 - Browse repository at this point
Copy the full SHA a35fb33View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4a61e8 - Browse repository at this point
Copy the full SHA a4a61e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93fbc12 - Browse repository at this point
Copy the full SHA 93fbc12View commit details -
Drop clumsy timeout on discovery notifications
It's better to just let goroutines fallback to their longer retry intervals then try to be clever here.
Configuration menu - View commit details
-
Copy full SHA for d6b1496 - Browse repository at this point
Copy the full SHA d6b1496View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac90d1d - Browse repository at this point
Copy the full SHA ac90d1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec81fc9 - Browse repository at this point
Copy the full SHA ec81fc9View commit details
Commits on Sep 27, 2016
-
Configuration menu - View commit details
-
Copy full SHA for ac29e9c - Browse repository at this point
Copy the full SHA ac29e9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64aa187 - Browse repository at this point
Copy the full SHA 64aa187View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91936f4 - Browse repository at this point
Copy the full SHA 91936f4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.