Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry all servers on RPC call failure #1735

Merged
merged 14 commits into from
Sep 27, 2016
Merged

Retry all servers on RPC call failure #1735

merged 14 commits into from
Sep 27, 2016

Commits on Sep 23, 2016

  1. Retry all servers on RPC call failure

    rpcproxy is refactored into serverlist which prioritizes good servers
    over servers in a remote DC or who have had a failure.
    
    Registration, heartbeating, and alloc status updating will retry faster
    when new servers are discovered.
    
    Consul discovery will be retried more quickly when no servers are
    available (eg on startup or an outage).
    schmichael committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    64ac9b9 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2016

  1. Replace periodic handlers with event driven disco

    Remove use of periodic consul handlers in the client and just use
    goroutines. Consul Discovery is now triggered with a chan instead of
    using a timer and deadline to trigger.
    
    Once discovery is complete a chan is ticked so all goroutines waiting
    for servers will run.
    
    Should speed up bootstraping and recovery while decreasing spinning on
    timers.
    schmichael committed Sep 24, 2016
    Configuration menu
    Copy the full SHA
    6d9670e View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2016

  1. Fix agent server set test

    Test asserted endpoint appendend servers, but the new/desired behavior
    is for the endpoint to set/overwrite servers.
    schmichael committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    6b9be92 View commit details
    Browse the repository at this point in the history
  2. consul -> Consul

    schmichael committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    01ff307 View commit details
    Browse the repository at this point in the history
  3. noServers -> noServersErr

    schmichael committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    3bac143 View commit details
    Browse the repository at this point in the history
  4. doDisco -> triggerDiscoveryCh; discovered -> serversDiscoveredCh

    Also fix log line formatting
    schmichael committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    a35fb33 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a4a61e8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    93fbc12 View commit details
    Browse the repository at this point in the history
  7. Drop clumsy timeout on discovery notifications

    It's better to just let goroutines fallback to their longer retry
    intervals then try to be clever here.
    schmichael committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    d6b1496 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ac90d1d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ec81fc9 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2016

  1. Remove unused const

    schmichael committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    ac29e9c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    64aa187 View commit details
    Browse the repository at this point in the history
  3. Cleanup changelog entries

    schmichael committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    91936f4 View commit details
    Browse the repository at this point in the history