Adding support for log driver settings and volume bindings #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 20, 2016 09:41
…u don't want to bake certificates into the container, you can mount them into the directory directly. Furthermore, I added support for volumes-from. Currently, there is no support to move the data from one container to another, hence: If a container spawns on another host, it is very likely, that the data will not be found.
Before this commit, if the Logging config did not contain a logging option "syslog-address", it would definitely insert this option. If then, you decide to take another logdriver than syslog, docker would fail because it received a wrong log option for the selected driver. Now, nomad will only insert the syslog address in a hard way if there are no logging options at all - this way it keeps the default nomad settings.
|
Thanks for the PR! We on the nomad team wanted to put these settings behind an off-by-default configuration option since they do pose some security issues. Follow #1767 if you're interested in knowing when this feature lands in master. It will be in the 0.5 release which should be out in the next few weeks. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for log driver settings passed through the docker run command.
Docker has various log-drivers and coming with that a couple of log options for each drivers.
As of now, nomad would only support syslog writing to a nomad specific location.
To use nomad in an environment with an existing logging infrastructure like awslog or SPLUNK, it is necessary to pass the right combination of settings to the docker run command.
This PR enables to insert a logging options block in the docker driver config in a nomad manifest.
Furthermore, it is now possible to mount host folders into containers and to use data volume container.
It could look like this:
`config {
image = "redis:latest"
port_map {
db = 6379
}
volumes = ["/path/on/host:/path/in/container", "...", "..."]
volumes_from = [
"datastorage"
]
logging {
type = "syslog"
config {
syslog-address = "tcp://127.0.0.1:1514"
tag = "your/logging/tag/{{.ImageName}}/{{.Name}}"
syslog-format = "rfc3164"
}
}
}`