Create a lint workflow for copyright checking #17378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a future improvement, perhaps we can migrate the `make check` tests here to run them in parallel and also allow for surfacing annotations from linting.
|
Thanks @dekimsey! Detecting these missing headers early is a good improvement 😄 Do you know which version of the CLI is used and if it would it include this fix? hashicorp/copywrite#59 |
tgross
reviewed
Jun 5, 2023
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Setup Copywrite | ||
| uses: hashicorp/setup-copywrite@867a1a2a064a0626db322392806428f7dc59cb3e # v1.1.2 |
There was a problem hiding this comment.
I thought we didn't need to pin hashicorp/* namespaced actions? It would be nice to be able to automatically pick up updates to the action without having to deal with a dependabot update
|
Superceded by #17889 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a lint workflow that verifies files have the required copyright headers. This allows us to be more proactive regarding copyright changes before the bot comes around and asks for changes.
I've created this as a generic workflow "Lint" so that we have a place to possibly surface
make checktests to our contributors.Discovered during #17103
Since we are adding a lint to an existing repository, I've gone ahead and applied the fix to failing files. Attached is an example of the copyright lint action failing:
