Convert example job file constraint to comment #1743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the "getting started" happy path experience for non-linux users who are running the native Docker tools on their machines. There is no need to constrain this job to linux, since driver detection for docker will already (basically) do this.
sethvargo
added a commit
that referenced
this pull request
Sep 24, 2016
- Uses spaces instead of tabs for the sample job file. Even though Nomad is written in Go, the HCL style guide uses two spaces for indentation, and this will match Terraform and Vault in terms of configuration. - Locks to redis:3.2 instead of floating latest. Running latest in production is a bad idea and we shouldn't encourage it even via example. - Removes the linux constraint (native docker exists for both Mac and Windows now) - Aligns equal signs and stuff as per the HCL formatter - Closes #1743
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the "getting started" happy path experience for non-linux users who are running the native Docker tools on their machines. There is no need to constrain this job to linux, since driver detection for docker will already (basically) do this.
/cc @dadgar @KFishner