node pools: implement CLI for node pool jobs command
#17432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
reviewed
Jun 5, 2023
tgross
force-pushed
the
f-node-pool-jobs-cli
branch
2 times, most recently
from
3fcab28
to
541de17
Compare
tgross
force-pushed
the
f-node-pool-jobs-cli
branch
from
541de17
to
d44a76a
Compare
tgross
force-pushed
the
f-node-pool-jobs-cli
branch
from
d44a76a
to
4b70e42
Compare
lgfa29
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
LGTM! The general -namespace website docs needs to be updated since it's not just job and alloc subcommands anymore 😅
https://github.com/hashicorp/nomad/blob/main/website/content/partials/general_options.mdx?plain=1#L10
The CLI help is already fixed:
https://github.com/hashicorp/nomad/blob/main/command/meta.go#L363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP this PR current includes everything in #17431. I'll rebase once that's been merged.