[ui] Parallelize ember tests #17442
Merged
[ui] Parallelize ember tests #17442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Test Audit comparison
|
gulducat
approved these changes
Jun 6, 2023
| ); | ||
| const servicedAlloc = (server.db.allocations.filter( | ||
| (a) => a.jobId === 'service-haver' | ||
| ) || [])[0]; |
There was a problem hiding this comment.
[][0] == undefined
javascript is amazing.
ChaiWithJai
reviewed
Jun 7, 2023
Comment on lines
742
to
748
| console.log('+++++ LOGGING ALLOC DETAILS +++++'); | ||
| console.log('Allocs found: ', findAll('tr[data-test-allocation]').length); | ||
| console.log('(locally, 1)'); | ||
| await percySnapshot(assert); | ||
|
|
||
| console.log('+++++ END LOGGING ALLOC DETAILS +++++'); | ||
|
|
There was a problem hiding this comment.
nit: Do you want to commit these logs?
philrenaud
force-pushed
the
17441-ui-dx-parallelize-ember-tests-on-pr
branch
from
0abb4fc
to
5eeb600
Compare
lgfa29
pushed a commit
that referenced
this pull request
Jun 22, 2023
* Exam to parallelize tests * Logging to try to solve test flakiness * Logging in another failure * Hardening for one test and snapshot for another * Explicitly set the first one as the servicedAlloc instead of randomly picking * A wild CircleCI test failure appears * de-log
lgfa29
pushed a commit
that referenced
this pull request
Jun 22, 2023
* Exam to parallelize tests * Logging to try to solve test flakiness * Logging in another failure * Hardening for one test and snapshot for another * Explicitly set the first one as the servicedAlloc instead of randomly picking * A wild CircleCI test failure appears * de-log
This was referenced Jun 22, 2023
lgfa29
added a commit
that referenced
this pull request
Jun 22, 2023
lgfa29
pushed a commit
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Ember Exam to parallelize tests; includes a few fixes for tests that are affected by leaks more than others. Surely more'll pop up eventually and we'll patch them when they do.