node pools: replicate from authoritative region #17456
Conversation
tgross
force-pushed
the
f-node-pool-federation
branch
from
9394da1
to
db7d7c9
Compare
tgross
force-pushed
the
f-node-pool-federation
branch
from
db7d7c9
to
2125233
Compare
tgross
force-pushed
the
f-node-pool-federation
branch
from
2125233
to
3a501bb
Compare
tgross
force-pushed
the
f-node-pool-federation
branch
from
3a501bb
to
4ac7252
Compare
| go s.replicateNamespaces(stopCh) | ||
| go s.replicateNodePools(stopCh) |
There was a problem hiding this comment.
While definitively not ideal in a real cluster do namespaces and node pools require ACLs to be enabled? I was bitten by this a few time while testing things and not seeing replication happening 😅
There was a problem hiding this comment.
Technically no, because the replication token will just be the zero value empty string. But if you check out the federation tutorial and ACL tutorial it really looks like we consider federation and replication as two different problems. You can have federation without replication and that just forwards requests around. But the purpose of replication seems entirely focused on ACLs. Namespaces are arguably ACL objects, and in the ENT case so are Node Pools. So I think we should probably keep the behavior we have here with namespaces.
Upserts and deletes of node pools are forwarded to the authoritative region, just like we do for namespaces, quotas, ACL policies, etc. Replicate node pools from the authoritative region.
tgross
force-pushed
the
f-node-pool-federation
branch
from
3f32818
to
64c5ae5
Compare
Upserts and deletes of node pools are forwarded to the authoritative region, just like we do for namespaces, quotas, ACL policies, etc. Replicate node pools from the authoritative region.