Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replication: fix potential panic during upgrades #17476

Merged
merged 2 commits into from
Jun 12, 2023
Merged

replication: fix potential panic during upgrades #17476

merged 2 commits into from
Jun 12, 2023

Commits on Jun 9, 2023

  1. replication: fix potential panic during upgrades 

    If the authoritative region has been upgraded to a version of Nomad that has new
replicated objects (such as ACL Auth Methods, ACL Binding Rules, etc.), the
non-authoritative regions will start replicating those objects as soon as their
leader is upgraded. If a server in the non-authoritative region is upgraded and
then becomes the leader before all the other servers in the region have been
upgraded, then it will attempt to write a Raft log entry that the followers
don't understand. The followers will then panic.

Add same the minimum version checks that we do for RPC writes to the leader's
replication loop.
    @tgross
    tgross committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    5ca181b View commit details
    Browse the repository at this point in the history

  2. address comments from code review

    @tgross
    tgross committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    a012912 View commit details
    Browse the repository at this point in the history