[ui] Job status panel: tooltips on individual allocs #17514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
commented
Jun 13, 2023
| role="tooltip" | ||
| aria-label="Allocations that have been rescheduled, on another node if possible, due to failure or manual restart" | ||
| > | ||
| <Hds::TooltipButton @text="Allocations that have been rescheduled, on another node if possible, due to failure or manual restart"> |
There was a problem hiding this comment.
Side-effect to update the tooltips here from custom-rolled ones to the official Helios tooltips.
Ember Test Audit comparison
|
lgfa29
suggested changes
Jun 13, 2023
There was a problem hiding this comment.
Changes LGTM, but I ran into an error when running make dev-ui:
Sass Syntax Error (SassCompiler) in /var/folders/sp/tb0_nysd40qf4w5jdhxgs8440000gp/T/broccoli-77574aZB57CvmdynR/out-700-funnel//app/styles/components/tooltip.scss:14:15
Error: Undefined variable.
╷
14 │ background: $black;
│ ^^^^^^
╵
/var/folders/sp/tb0_nysd40qf4w5jdhxgs8440000gp/T/broccoli-77574aZB57CvmdynR/out-700-funnel/app/styles/components/tooltip.scss 14:15 @use
/var/folders/sp/tb0_nysd40qf4w5jdhxgs8440000gp/T/broccoli-77574aZB57CvmdynR/out-700-funnel/app/styles/@hashicorp/design-system-components.scss 43:1 @import
/var/folders/sp/tb0_nysd40qf4w5jdhxgs8440000gp/T/broccoli-77574aZB57CvmdynR/out-700-funnel/app/styles/app.scss 11:9 root stylesheet
Stack Trace and Error Report: /var/folders/sp/tb0_nysd40qf4w5jdhxgs8440000gp/T/error.dump.30842f53940c5a14089c1686e757354d.log
make: *** [ember-dist] Error 1
I think our tooltip.scss is conflicting with Helios tooltip.scss.
I renamed our file to legacy-tooltip.scss to fix it.
philrenaud
deleted the
17513-ui-deployments-tooltip-showing-group-name-and-alloc_id-on-alloc-box-hover
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the latest Helios (Hashicorp Design System) and includes new
<Hds::Tooltip>elements to allocations in the status panel, showing theirshortId.This does not add any tooltip to "grouped" allocation blocks (the "+4" and "+3" blocks in the screenshot below).