Add "nomad.client.host.cpu.total_ticks" to metrics #17578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
force-pushed
the
host-cpu-total-ticks
branch
from
2d972aa to
8d61673
Compare
TrueBrain
force-pushed
the
host-cpu-total-ticks
branch
from
8d61673 to
d519526
Compare
TrueBrain
force-pushed
the
host-cpu-total-ticks
branch
from
d519526 to
a7a62d7
Compare
|
@TrueBrain I'm going to close this PR in lieu of keeping this work together with what you submitted in #17579 (which I'm reviewing now). I do appreciate that you tried to break it up into reviewable chunks! But I think these two PRs belong together and I want to address them as one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is
nomad.client.allocs.cpu.total_ticksandnomad.client.allocs.cpu.total_percentfor allocations, butnomad.client.host.cpu.totalonly has that, which is a percentage.To keep things more the same, this PR adds
total_ticksandtotal_percentfornomad.client.host.cputoo. This means that allcpuobjects have at leastsystem,user,total_percentandtotal_ticks.I also kept
nomad.client.host.cpu.total, as I am sure there are people using this field; and removing it would break their work. Which seems like a bad idea. One could argue thattotal_percentdoesn't need to be added, but this makes it a bit unclear whattotalactually is.PS: honestly not sure this PR is worth it; my OCD triggered, that was the whole reason I have to admit :)