Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node pools: apply node pool scheduler configuration #17598

Merged
merged 7 commits into from
Jun 22, 2023
Merged

node pools: apply node pool scheduler configuration #17598

merged 7 commits into from
Jun 22, 2023

Commits on Jun 19, 2023

  1. np: check pool memory oversubscription on job registration

    @lgfa29
    lgfa29 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    21e49da View commit details
    Browse the repository at this point in the history

  2. np: apply node pool scheduler config

    @lgfa29
    lgfa29 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    b32258b View commit details
    Browse the repository at this point in the history

  3. docs: add node pool memory oversubscription notes

    @lgfa29
    lgfa29 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    2908d54 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. core: set proper job, node pool, and nodes on downgrade 

    When a non-canary allocation fails during a canary deployment it must be
replaced according to the original job specification, which includes
resources, constraints, node pool, datacenters etc.

Prior to this change, only job was being reset in the stack, which could
lead to the replacement being placed in nodes in the wrong node pool or
datacenter and nodes being scored with the wrong scheduler configuration.
    @lgfa29
    lgfa29 committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    b99e8c5 View commit details
    Browse the repository at this point in the history

  2. apply code review

    @lgfa29
    lgfa29 committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    b62d43b View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. core: follow the same setNode pattern from generic scheduler in the s… 

    …ystem scheduler
    @lgfa29
    lgfa29 committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    7422636 View commit details
    Browse the repository at this point in the history

  2. np: add note about the scheduler and per node pool scheduler configur… 

    …ation
    @lgfa29
    lgfa29 committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    6b07aed View commit details
    Browse the repository at this point in the history