Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: tolerate having only one dynamic port available #17619

Merged
merged 1 commit into from
Jun 20, 2023
Merged

scheduler: tolerate having only one dynamic port available #17619

merged 1 commit into from
Jun 20, 2023

Commits on Jun 20, 2023

  1. scheduler: tolerate having only one dynamic port available 

    If the dynamic port range for a node is set so that the min is equal to the max,
there's only one port available and this passes config validation. But the
scheduler panics when it tries to pick a random port. Only add the randomness
when there's more than one to pick from.

Adds a test for the behavior but also adjusts the commentary on a couple of the
existing tests that made it seem like this case was already covered if you
didn't look too closely.

Fixes: #17585
    @tgross
    tgross committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    e9e4358 View commit details
    Browse the repository at this point in the history