Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: set proper nodes on downgrade #17653

Merged
merged 3 commits into from
Jun 22, 2023
Merged

core: set proper nodes on downgrade #17653

merged 3 commits into from
Jun 22, 2023

Commits on Jun 22, 2023

  1. core: set proper nodes on downgrade 

    When a non-canary allocation fails during a canary deployment it must be
replaced according to the original job specification, which includes
resources, constraints, datacenters etc.

Prior to this change, only the job was being reset in the stack, which
could lead to the replacement being placed in nodes in the wrong
datacenter.
    @lgfa29
    lgfa29 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    b45a1fe View commit details
    Browse the repository at this point in the history

  2. changelog: add entry for #17653

    @lgfa29
    lgfa29 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    f271497 View commit details
    Browse the repository at this point in the history

  3. apply code review changes

    @lgfa29
    lgfa29 committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    2f10560 View commit details
    Browse the repository at this point in the history