Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/docker: refactor use of clients in docker driver #17731

Merged
merged 2 commits into from
Jun 26, 2023
Merged

drivers/docker: refactor use of clients in docker driver #17731

merged 2 commits into from
Jun 26, 2023

Commits on Jun 26, 2023

  1. drivers/docker: refactor use of clients in docker driver 

    This PR refactors how we manage the two underlying clients used by the
docker driver for communicating with the docker daemon. We keep two clients
- one with a hard-coded timeout that applies to all operations no matter
what, intended for use with short lived / async calls to docker. The other
has no timeout and is the responsibility of the caller to set a context
that will ensure the call eventually terminates.

The use of these two clients has been confusing and mistakes were made
in a number of places where calls were making use of the wrong client.

This PR makes it so that a user must explicitly call a function to get
the client that makes sense for that use case.

Fixes #17023
    @shoenig
    shoenig committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    185a374 View commit details
    Browse the repository at this point in the history

  2. cr: followup items

    @shoenig
    shoenig committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    cab26a0 View commit details
    Browse the repository at this point in the history