Backport of drivers/docker: refactor use of clients in docker driver into release/1.4.x #17740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/docker-max-kill-timeout/indirectly-powerful-terrapin
branch
from
357dcd0
to
792ec45
Compare
hc-github-team-nomad-core
force-pushed
the
backport/docker-max-kill-timeout/indirectly-powerful-terrapin
branch
from
792ec45
to
357dcd0
Compare
|
|
(just the bug fix, not the refactoring)
shoenig
force-pushed
the
backport/docker-max-kill-timeout/indirectly-powerful-terrapin
branch
from
7d1bf10
to
edb9626
Compare
shoenig
deleted the
backport/docker-max-kill-timeout/indirectly-powerful-terrapin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17731 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
This PR refactors how we manage the two underlying clients used by the
docker driver for communicating with the docker daemon. We keep two clients
One with a hard-coded timeout that applies to all operations no matter
what, intended for use with short lived / async calls to docker.
The other has no timeout and is the responsibility of the caller to set a
context that will ensure the call eventually terminates (except in the
.Waitcase).The use of these two clients has been confusing and mistakes were made
in a number of places where calls were making use of the wrong client.
This PR makes it so that a user must explicitly call a function to get
the client that makes sense for that use case.
Fixes #17023