Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

volume-status : show namespace the volume belongs to #17911

Merged
merged 3 commits into from
Jul 19, 2023
Merged

volume-status : show namespace the volume belongs to #17911

merged 3 commits into from
Jul 19, 2023

Conversation

the-nando
Copy link
Contributor

@the-nando the-nando commented Jul 12, 2023 •
edited

Fixes: #17912

@the-nando the-nando mentioned this pull request Jul 12, 2023
Closed
@jrasell jrasell added this to the 1.6.x milestone Jul 12, 2023
@jrasell jrasell added this to Needs Triage in Nomad - Community Issues Triage via automation Jul 12, 2023
lgfa29
lgfa29 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, thanks for the PR @the-nando!

I guess you noticed the same thing as I did in #17925 but did a much better job at it 😄

We're in the release candidate period, where only significant bug fixes will be merged for now, so I will keep this open until GA happens.

@lgfa29 lgfa29 added backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line labels Jul 12, 2023
lgfa29 added a commit that referenced this pull request Jul 12, 2023
@lgfa29
cli: undo volume namespace output since it's done in #17911
06e38d6
@lgfa29 lgfa29 mentioned this pull request Jul 12, 2023
Merged
@lgfa29 lgfa29 removed backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line labels Jul 12, 2023
@the-nando
Copy link
Contributor Author

@lgfa29 nothing urgent and thanks!
There's a couple of failing test actions which look like unrelated to this change

@lgfa29
Copy link
Contributor

lgfa29 commented Jul 19, 2023

There's a couple of failing test actions which look like unrelated to this change

Yeah, it kind of does that sometimes 🤷

@lgfa29 lgfa29 merged commit ca26673 into hashicorp:main Jul 19, 2023
26 of 27 checks passed
Nomad - Community Issues Triage automation moved this from Needs Triage to Done Jul 19, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jul 19, 2023
Merged
jrasell pushed a commit that referenced this pull request Jul 26, 2023
@the-nando @jrasell
volume-status : show namespace the volume belongs to (#17911)
476c2aa 
* volume-status : show namespace the volume belongs to
This was referenced Aug 1, 2023
Merged
Merged
Merged
lgfa29 pushed a commit that referenced this pull request Aug 17, 2023
@the-nando @lgfa29
volume-status : show namespace the volume belongs to (#17911)
7c1c9b0 
* volume-status : show namespace the volume belongs to

Re-apply changes reverted by 950235d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

Assignees
No one assigned
Labels
backport/1.6.x backport to 1.6.x release line
Projects
Nomad - Community Issues Triage
Archived in project
Nomad - Community Issues Triage
Done
Milestone
1.6.x
Development

Successfully merging this pull request may close these issues.

CLI : volume status show namespace
3 participants
@the-nando @lgfa29 @jrasell