Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: make snapshot name requiered in creating volume snapshots #17958

Merged
merged 3 commits into from
Aug 4, 2023
Merged

CLI: make snapshot name requiered in creating volume snapshots #17958

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7232d3
CLI: make snapshot name requiered in creating volume snapshots
yazdan Jul 16, 2023
f274147
Review addressed and changlog added
yazdan Jul 29, 2023
0c23733
Update .changelog/17958.txt
yazdan Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/17958.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
cli: make snapshot name requiered in creating volume snapshots
yazdan marked this conversation as resolved.
Show resolved Hide resolved
```
24 changes: 10 additions & 14 deletions command/volume_snapshot_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,16 @@ type VolumeSnapshotCreateCommand struct {

func (c *VolumeSnapshotCreateCommand) Help() string {
helpText := `
Usage: nomad volume snapshot create <volume id> [snapshot_name]
Usage: nomad volume snapshot create <volume id> <snapshot_name>

Create a snapshot of an external storage volume. This command requires a
volume ID or prefix. If there is an exact match based on the provided volume
ID or prefix, then the specific volume is snapshotted. Otherwise, a list of
matching volumes and information will be displayed. The volume must still be
registered with Nomad in order to be snapshotted.
volume ID or prefix and snapthost name. If there is an exact match based on
the provided volume ID or prefix, then the specific volume is snapshotted.
Otherwise, a list of matching volumes and information will be displayed. The
volume must still be registered with Nomad in order to be snapshotted.

If an optional snapshot name is provided, the argument will be passed to the
CSI plugin to be used as the ID of the resulting snapshot. Not all plugins
accept this name and it may be ignored.
Snapshot name will be passed to the CSI plugin to be used as the ID of the
resulting snapshot.

When ACLs are enabled, this command requires a token with the
'csi-write-volume' capability for the volume's namespace.
Expand Down Expand Up @@ -100,16 +99,13 @@ func (c *VolumeSnapshotCreateCommand) Run(args []string) int {

// Check that we at least one argument
args = flags.Args()
if l := len(args); l == 0 {
c.Ui.Error("This command takes at least one argument: <vol id> [snapshot name]")
if l := len(args); l != 2 {
c.Ui.Error("This command takes two arguments: <vol id> <snapshot name>")
c.Ui.Error(commandErrorText(c))
return 1
}
volID := args[0]
snapshotName := ""
if len(args) == 2 {
snapshotName = args[1]
}
snapshotName := args[1]

// Get the HTTP client
client, err := c.Meta.Client()
Expand Down