Retain task states for post stop tasks at the time of node GC #18005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe that |
schmichael
approved these changes
Jul 21, 2023
schmichael
added
backport/1.4.x
|
Tested and looks good to me! Thanks for the great work debugging and fixing this. I pushed up a changelog entry, added backport labels, and will merge as soon as tests are happy. |
This was referenced Jul 21, 2023
Merged
Merged
jrasell
pushed a commit
that referenced
this pull request
Jul 26, 2023
* Retain task states for post stop tasks at the time of node GC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persist the task states for post stop tasks at the time of killing to resolve #17971.
Please note that this is the safer of the two options discussed within the original issue description.