Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple fixes to make Docker For Mac work #1806

Merged
merged 5 commits into from
Oct 27, 2016
Merged

Commits on Oct 13, 2016

  1. Resolve alloc/state directories to make Docker For Mac happy

    * In -dev mode, `ioutil.TempDir` is used for the alloc and state
    directories.
    * `TempDir` uses `$TMPDIR`, which os OS X contains a per user
    directory which is under `/var/folder`.
    * `/var` is actually a symlink to `/private/var`
    * Docker For Mac validates the directories that are passed to bind and on
    OS X. That whitelist contains `/private`, but not `/var`. It does not
    expand the path, and so any paths in `$TMPDIR` fail the whitelist check.
    
    And thusly, by expanding the alloc/state directories the value passed
    for binding does contain `/private` and Docker For Mac is happy.
    evanphx committed Oct 13, 2016
    Configuration menu
    Copy the full SHA
    04e1e02 View commit details
    Browse the repository at this point in the history
  2. Disable the syslog logging system on Docker For Mac

    The syslog logging system depends on the ability for a unix socket to be
    accessed by the docker daemon in the $TMPDIR of the host. This doesn't
    work on Docker For Mac because the docker daemon is running inside a VM,
    and while /tmp is accessible, the filesystem used to share them doesn't
    support unix socket files, and thus it doesn't work.
    evanphx committed Oct 13, 2016
    Configuration menu
    Copy the full SHA
    cb64cfe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e2c0abd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5f2b967 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2016

  1. Fix panic

    dadgar committed Oct 26, 2016
    Configuration menu
    Copy the full SHA
    00ce1e5 View commit details
    Browse the repository at this point in the history