Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allocwatcher: don't destroy local allocdir after migration #18108

Merged
merged 1 commit into from
Aug 2, 2023

Commits on Aug 1, 2023

  1. allocwatcher: don't destroy local allocdir after migration

    When ephemeral disks are migrated from an allocation on the same node,
    allocation logs for the previous allocation are lost.
    
    There are two workflows for the best-effort attempt to migrate the allocation
    data between the old and new allocations. For previous allocations on other
    clients (the "remote" workflow), we create a local allocdir and download the
    data from the previous client into it. That data is then moved into the new
    allocdir and we delete the allocdir of the previous alloc.
    
    For "local" previous allocations we don't need to create an extra directory for
    the previous allocation and instead move the files directly from one to the
    other. But we still delete the old allocdir _entirely_, which includes all the
    logs!
    
    There doesn't seem to be any reason to destroy the local previous allocdir, as
    the usual client garbage collection should destroy it later on when needed. By
    not deleting it, the previous allocation's logs are still available for the user
    to read.
    
    Fixes: #18034
    tgross committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a3a637e View commit details
    Browse the repository at this point in the history