Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: filter device instance IDs by constraints #18141

Merged
merged 1 commit into from
Aug 3, 2023
Merged

scheduler: filter device instance IDs by constraints #18141

merged 1 commit into from
Aug 3, 2023

Commits on Aug 3, 2023

  1. scheduler: filter device instance IDs by constraints 

    When the scheduler assigns a device instance, it iterates over the feasible
devices and then picks the first instance with availability. If the jobspec uses
a constraint on device ID, this can lead to buggy/surprising behavior where the
node's device matches the constraint but then the individual device instance
does not.

Add a second filter based on the `${device.ids}` constraint after selecting a
node's device to ensure the device instance ID falls within the constraint as
well.

Fixes: #18112
    @tgross
    tgross committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    a471800 View commit details
    Browse the repository at this point in the history