Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of update go1.21 into release/1.4.x #18194

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #18184 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


This PR updates the build system to use go1.21. In addition,

  • update golangci-lint
  • eliminate the Min/Max helpers for the now builtin min/max
  • swap out depguard and use semgrep instead (was failing with go1.21, and has been troublesome in the past too)
  • fixup a TLS error string check that seemingly changed in go1.21

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/update-go1.21/sadly-sweet-mole branch 2 times, most recently from 14598d1 to 8aa1950 Compare August 14, 2023 13:43
@hashicorp-cla
Copy link

hashicorp-cla commented Aug 14, 2023

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot temporarily deployed to Preview – nomad August 14, 2023 13:48 Inactive
(manual cherry-pick of d9341f0)

* build: update to go1.21

* go: eliminate helpers in favor of min/max

* build: run go mod tidy

* build: swap depguard for semgrep

* command: fixup broken tls error check on go1.21
@shoenig shoenig merged commit 6850092 into release/1.4.x Aug 14, 2023
22 of 24 checks passed
@shoenig shoenig deleted the backport/update-go1.21/sadly-sweet-mole branch August 14, 2023 14:22
sundbry added a commit to arctype-co/nomad that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants