Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: move glossary to a top-level menu item #18223

Merged
merged 1 commit into from
Aug 16, 2023
Merged

docs: move glossary to a top-level menu item #18223

merged 1 commit into from
Aug 16, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Aug 16, 2023

@lgfa29 lgfa29 requested a review from a team August 16, 2023 17:36
@lgfa29 lgfa29 added backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.6.x backport to 1.6.x release line labels Aug 16, 2023
gulducat
gulducat approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not closely proof-read all the contents of the glossary entries to confirm happy copy/paste, but the structural change LGTM!

@lgfa29
Copy link
Contributor Author

lgfa29 commented Aug 16, 2023

Yeah, I pretty much just moved content around, no actual change in text 👍

@lgfa29 lgfa29 merged commit 6d1a2a0 into main Aug 16, 2023
11 checks passed
@lgfa29 lgfa29 deleted the docs-move-glossary branch August 16, 2023 21:22
@lgfa29 lgfa29 added backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.6.x backport to 1.6.x release line and removed backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.6.x backport to 1.6.x release line labels Aug 16, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Aug 16, 2023
Merged
@lgfa29 lgfa29 added backport/1.6.x backport to 1.6.x release line and removed backport/1.6.x backport to 1.6.x release line labels Aug 16, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Aug 16, 2023
Merged
@lgfa29 lgfa29 added backport/1.6.x backport to 1.6.x release line and removed backport/1.6.x backport to 1.6.x release line labels Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gulducat gulducat gulducat approved these changes

Assignees
No one assigned
Labels
backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.6.x backport to 1.6.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgfa29 @gulducat