Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: 404 when accessing files for GC'ed alloc #18232

Merged
merged 7 commits into from
Aug 21, 2023
Merged

Commits on Aug 17, 2023

  1. client: 404 when accessing files for GC'ed alloc

    When an allocation is garbage collected from the client, but not from
    the servers, the API request is routed to the client and the client
    does attempt to read the file, but the alloc dir has already been
    deleted, resulting in a 500 error.
    
    This happens because the client GC only destroys the alloc runner
    (deleting the alloc dir), but it keeps a reference to the alloc runner
    until the alloc is garbage collected from the servers as well.
    
    This commit adjusts this logic by checking if the alloc runner (and the
    alloc files) has been destroyed, returning a 404 if so.
    lgfa29 committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    e705558 View commit details
    Browse the repository at this point in the history
  2. changelog: add entry for #18232

    lgfa29 committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    23d06cd View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Configuration menu
    Copy the full SHA
    eb0a087 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    48a5407 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c14d770 View commit details
    Browse the repository at this point in the history
  4. fix tests

    lgfa29 committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    36e48e1 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Configuration menu
    Copy the full SHA
    15f9430 View commit details
    Browse the repository at this point in the history