Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of client: 404 when accessing files for GC'ed alloc into release/1.4.x #18273

Merged

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #18232 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


When an allocation is garbage collected from the client, but not from the servers, the API request is routed to the client and the client does attempt to read the file, but the alloc files have already been deleted, resulting in a 500 error.

This happens because the client GC only destroys the alloc runner (deleting the alloc dir), but it keeps a reference to the alloc runner until the alloc is garbage collected from the servers as well.

This commit adjusts this logic by checking if the alloc runner (and the alloc files) has been destroyed, returning a 404 if so.

Closes #18216


Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-return-404-on-gc-alloc/briefly-dynamic-elf branch 2 times, most recently from 30c5061 to 4e3a5c5 Compare August 21, 2023 20:09
@vercel vercel bot temporarily deployed to Preview – nomad August 21, 2023 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui August 21, 2023 20:18 Inactive
@lgfa29 lgfa29 merged commit 53e999d into release/1.4.x Aug 21, 2023
23 of 25 checks passed
@lgfa29 lgfa29 deleted the backport/b-return-404-on-gc-alloc/briefly-dynamic-elf branch August 21, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants