Backport of Ensure that the index processed by the client is at least as new as the last one processed. into release/1.4.x #18339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/18267-Nomad-Server-may-stop-all-client-workloads/abnormally-curious-wildcat
branch
from
380a605
to
92623b9
Compare
schmichael
deleted the
backport/18267-Nomad-Server-may-stop-all-client-workloads/abnormally-curious-wildcat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18269 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
The below text is copied from the body of the original PR.
A fix for #18267, ensuring that "time travel" of the client state is not possible.
I could not find tests which may exercise this logic meaningfully. Please point me the right direction and I'm happy to add them
Please note that this isn't an actual good fix to the underlying issue, but rather a stop-gap measure.
Overview of commits