Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of client: fix role permission issue with duplicate policies. into release/1.6.x #18448

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #18419 to be assessed for backporting due to the inclusion of the label backport/1.6.x.

The below text is copied from the body of the original PR.


This change deduplicates the ACL policy list generated from ACL roles referenced within an ACL token on the client.

Previously the list could contain duplicates, which would cause erronous permission denied errors when calling client related RPC/ HTTP API endpoints. This is because the client calls the ACL get policies endpoint which subsequently ensures the caller has permission to view the ACL policies. This check is performed by comparing the requested list args with the policies referenced by the caller ACL token. When a duplicate is present, this check fails, as the check must ensure the slices match exactly.

The linked issue has details on how to reproduce the problem, if readers want to test this before and after the code changes.

Closes #17201


Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/gh-17201/heartily-obliging-sunbeam branch 2 times, most recently from 6dfd301 to 994ff5c Compare September 11, 2023 11:52
@vercel vercel bot temporarily deployed to Preview – nomad September 11, 2023 11:58 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui September 11, 2023 12:03 Inactive
@jrasell jrasell merged commit 7cb74cc into release/1.6.x Sep 11, 2023
22 of 25 checks passed
@jrasell jrasell deleted the backport/gh-17201/heartily-obliging-sunbeam branch September 11, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants