Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of CSI: Expand Volume (Controller only) into release/1.6.x #18505

Merged

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #18359 to be assessed for backporting due to the inclusion of the label backport/1.6.x.

The below text is copied from the body of the original PR.


Addresses #10324 with declarative config (instead of a new imperative command/api route).

I still need to update docs, but to trigger a volume increase, modify the volume specification that was used initially to create/register the volume with a higher capacity_min (and optionally capacity_max), then issue create or register again.

This introduces a comparatively very slow process into the create/register flow (if expand is actually needed), and modifies the behavior of create to be more idempotent than it currently is (presently it always issues create to the controller plugin).

I hemmed and hawed a lot on where the validation logic should live, so I'd be happy to hear any suggestions to move any of it. I mainly want to avoid putting it right before writing to raft, because by that point reality (a real live disk in the world) may have already changed.

The commit history is messy right now; I intend to squash it before merging.

So far this covers ControllerExpandVolume to increase volumes outside of the instance (e.g. an AWS EBS volume), but does not yet complete the process (when required) with NodeExpandVolume on the node where the volume is mounted. I think I'll make that a separate PR.


Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/csi-resize-redux/conversely-concrete-bullfrog branch from 9f9e316 to b88a403 Compare September 14, 2023 19:13
@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/csi-resize-redux/conversely-concrete-bullfrog branch from 7b70f77 to 5c477b8 Compare September 14, 2023 19:13
@gulducat gulducat merged commit 510e4d2 into release/1.6.x Sep 14, 2023
25 checks passed
@gulducat gulducat deleted the backport/csi-resize-redux/conversely-concrete-bullfrog branch September 14, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants