config: fix some issues with workload identity and multi Consul and Vault #18590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capture the loop variable when parsing multiple Consul and Vault configuration blocks so the duration parse function uses the correct field when it's called later on.
When setting up the multiple Vault clients, the code was always loading the default configuration, resulting in all clients to be configured the same way.
Ensure `WorkloadIdentityConfig.Copy()` does not return the original pointer for the `TTL` field.
lgfa29
changed the title
lgfa29
commented
Sep 26, 2023
| vaultClient, err := vaultclient.NewVaultClient(c.GetConfig().VaultConfig, c.logger, c.deriveToken) | ||
| vaultClient, err := vaultclient.NewVaultClient(vaultConfig, c.logger, c.deriveToken) |
There was a problem hiding this comment.
This fix will be tested in the ENT repo since GetVaultConfigs() only returns the default config in CE.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking up #18534 into more manageable pieces, this PR fixes some small bugs in configuration parsing and handling of workload identity and multi Consul and Vault.
Each commit contains a specific bug fix.