Backport of scaling: set Index on nil-job scale status reply into release/1.6.x #18648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18637 to be assessed for backporting due to the inclusion of the label backport/1.6.x.
The below text is copied from the body of the original PR.
I noticed this while working on hashicorp/nomad-autoscaler#604 -- When a job went away, the blocking query on
/v1/job/{job-id}/scale
kept blocking for the full 5 minute timeout, instead of returning "not found" as soon as the job was purged/gc'd.returning a nil error in a
blockingOptions.run()
without increasing the reply
Index
can cause thequery to block indefinitely (until timeout).
this fixes that happening in
Job.ScaleStatus
when the job is deleted -- the job going away
should now return as not-found and provide a new
index for the caller to try if they so please.
Overview of commits