Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of cli: remove default for ACL token type on update into release/1.4.x #18718

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #18689 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


With a default value set to client, the nomad acl token update command can silently downgrade a management token to client on update if the command does not specify -type=management on every update.


Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-remove-acl-token-update-type-default/correctly-tidy-bass branch 2 times, most recently from 64941b1 to 7de56d6 Compare October 10, 2023 19:51
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui October 10, 2023 20:00 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad October 10, 2023 20:01 Inactive
@lgfa29 lgfa29 merged commit ed844c3 into release/1.4.x Oct 10, 2023
24 of 26 checks passed
@lgfa29 lgfa29 deleted the backport/b-remove-acl-token-update-type-default/correctly-tidy-bass branch October 10, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants