-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scheduler version enforcement #1872
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -134,8 +134,9 @@ func (w *Worker) run() { | |||||||||||||||||||||||||||||||||||||
func (w *Worker) dequeueEvaluation(timeout time.Duration) (*structs.Evaluation, string, bool) { | ||||||||||||||||||||||||||||||||||||||
// Setup the request | ||||||||||||||||||||||||||||||||||||||
req := structs.EvalDequeueRequest{ | ||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The worker should probably not sit in a hot loop of calling dequeue on this error, e.g. the failure is basically semi-permanent. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So I was thinking we want it to spam the logs so the operator knows they are doing something bad. On the error we start backing off: Lines 146 to 163 in 962f4d4
|
||||||||||||||||||||||||||||||||||||||
Schedulers: w.srv.config.EnabledSchedulers, | ||||||||||||||||||||||||||||||||||||||
Timeout: timeout, | ||||||||||||||||||||||||||||||||||||||
Schedulers: w.srv.config.EnabledSchedulers, | ||||||||||||||||||||||||||||||||||||||
Timeout: timeout, | ||||||||||||||||||||||||||||||||||||||
SchedulerVersion: scheduler.SchedulerVersion, | ||||||||||||||||||||||||||||||||||||||
WriteRequest: structs.WriteRequest{ | ||||||||||||||||||||||||||||||||||||||
Region: w.srv.config.Region, | ||||||||||||||||||||||||||||||||||||||
}, | ||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something about the
uint16
feels dirty...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It gives us a lot of versions while keeping it low overhead. We will never pass 65536 version bumps.