Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: ensure dup alloc names are fixed before plan submit. #18873

Merged
merged 4 commits into from
Oct 27, 2023

Commits on Oct 26, 2023

  1. scheduler: ensure dup alloc names are fixed before plan submit.

    This change fixes a bug within the generic scheduler which meant
    duplicate alloc indexes (names) could be submitted to the plan
    applier and written to state. The bug originates from the
    placements calculation notion that names of allocations being
    replaced are blindly copied to their replacement. This is not
    correct in all cases, particularly when dealing with canaries.
    
    The fix updates the alloc name index tracker to include minor
    duplicate tracking. This can be used when computing placements to
    ensure duplicate are found, and a new name picked before the plan
    is submitted. The name index tracking is now passed from the
    reconciler to the generic scheduler via the results, so this does
    not have to be regenerated, or another data structure used.
    jrasell committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d61265a View commit details
    Browse the repository at this point in the history
  2. changelog: add entry for #18873

    jrasell committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9fb64df View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Configuration menu
    Copy the full SHA
    965e9a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1240738 View commit details
    Browse the repository at this point in the history