Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: fix and modernize rescheduling test #19105

Merged
merged 4 commits into from
Nov 16, 2023
Merged

e2e: fix and modernize rescheduling test #19105

merged 4 commits into from
Nov 16, 2023

Commits on Nov 16, 2023

  1. e2e: fix and modernize rescheduling test 

    The E2E test suite for rescheduling had a few bugs:
* Using the command line to stop a job with a failing deployment returns a non-zero exit
  code, which would cause an otherwise passing test to fail.
* Two of the input jobs were actually invalid but were only correctly detected
  as such because of #17342

This changeset also updates the whole test suite to move it off the v1
"framework". The test assertions are otherwise left untouched.
    @tgross
    tgross committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    de74846 View commit details
    Browse the repository at this point in the history

  2. address comments from code review

    @tgross
    tgross committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    cb81f51 View commit details
    Browse the repository at this point in the history

  3. make the test helper a little nicer

    @tgross
    tgross committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    46a2c3e View commit details
    Browse the repository at this point in the history

  4. fix progress deadline fail test

    @tgross
    tgross committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    bc6e979 View commit details
    Browse the repository at this point in the history