Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose safer default advertise address #1955

Merged
merged 15 commits into from
Nov 10, 2016
Merged

Choose safer default advertise address #1955

merged 15 commits into from
Nov 10, 2016

Commits on Nov 8, 2016

  1. Choose safer default advertise address 

    * -dev mode defaults bind & advertise to localhost
* Normal mode defaults bind to 0.0.0.0 & advertise to the resolved
  hostname. If the hostname resolves to localhost it will refuse to
  start and advertise must be manually set.
    @schmichael
    schmichael committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    4e7587d View commit details
    Browse the repository at this point in the history

  2. Failure to resolve advertise address isn't fatal

    @schmichael
    schmichael committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    3dab503 View commit details
    Browse the repository at this point in the history

  3. Refactor getAdvertise into a func

    @schmichael
    schmichael committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    2c4b19f View commit details
    Browse the repository at this point in the history

  4. Handle missing ports in addresses

    @schmichael
    schmichael committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    581d6a5 View commit details
    Browse the repository at this point in the history

  5. Match old error messages

    @schmichael
    schmichael committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    9420e73 View commit details
    Browse the repository at this point in the history

  6. Move config normalization into config.go to ease testing

    @schmichael
    schmichael committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    5cc435a View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2016

  1. Fix int pointer formatting and server config test

    @schmichael
    schmichael committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    eb89fd2 View commit details
    Browse the repository at this point in the history

  2. Normalize configs for agent tests

    @schmichael
    schmichael committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    4f15cac View commit details
    Browse the repository at this point in the history

  3. Restore sync/atomic use for consistency

    @schmichael
    schmichael committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    4aed5ba View commit details
    Browse the repository at this point in the history

  4. Fix test that fails now that advertise can't be localhost

    @schmichael
    schmichael committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    1e0b4d7 View commit details
    Browse the repository at this point in the history

  5. Enable dev mode to allow using localhost in tests

    @schmichael
    schmichael committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    1893772 View commit details
    Browse the repository at this point in the history

  6. Addresses are just addresses - no ports 

    Store address+port in an unexported field for ease-of-use
    @schmichael
    schmichael committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    1304ba8 View commit details
    Browse the repository at this point in the history

  7. Add unit test for missing port helper func

    @schmichael
    schmichael committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    5fa84d5 View commit details
    Browse the repository at this point in the history

  8. Fix typo in test

    @schmichael
    schmichael committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    3b4fe9a View commit details
    Browse the repository at this point in the history

  9. Fix comment

    @schmichael
    schmichael committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    778dfef View commit details
    Browse the repository at this point in the history