Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl: remove timestamps from WhoAmI response #19578

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Commits on Jan 2, 2024

  1. acl: remove timestamps from WhoAmI response

    In Nomad 1.7 we updated our JWT library to go-jose, but this changed the wire
    format of the embedded struct we have in the `IdentityClaims` struct that we
    return as part of the `WhoAmI` RPC response. This wasn't originally intended to
    be sent over the wire but other changes in Nomad 1.5+ added a caller to the
    client. The library change causes a deserialization error on Nomad 1.5 and 1.6
    clients, which prevents access to Nomad Variables and SD via template blocks.
    
    Removed the incompatible fields from the response, which are unused by any
    current caller. In a future version of Nomad, we'll likely remove the `WhoAmI`
    callers from the client in lieu of using the public keys the clients have to
    check auth.
    
    Fixes: #19555
    tgross committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    0bdb10c View commit details
    Browse the repository at this point in the history