-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Remove json linting while editing variables #20529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (once tests are green) This was a nice to have but if someone is really having trouble with it, the form-editor interface is still there instead of the JSON mode. And it's all ultimately validated server side.
bc7d95b
to
2f19e0e
Compare
Even better, it'll still run a (It just won't be the pretty code-mirror-gutter style lint errors that showed exact position, etc.) |
Ember Test Audit comparison
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This removes the JSON Linting gutter highlight capabilities originally added in #13461
The main reason for this removal is the inclusion of a nested Underscore dependency: https://github.com/hashicorp/nomad/security/dependabot/110
However, our dependency (a grandparent of the insecure underscore version) has not been updated in quite some time and appears to be unmaintained.
As such, I've given consideration to whether this feature is worth forking, pinning, or abandoning. Per zaach/jsonlint#120 a change has been merged to
master
injsonlint
, but no release onnpm
has been made. As such, I've opted to remove the feature for the same reasons other projects have done so: it doesn't give enough benefit to warrant hanging on to an un-updated dependency for marginal utility.