Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Remove json linting while editing variables #20529

Merged
merged 1 commit into from
May 3, 2024

Conversation

philrenaud
Copy link
Contributor

This removes the JSON Linting gutter highlight capabilities originally added in #13461

The main reason for this removal is the inclusion of a nested Underscore dependency: https://github.com/hashicorp/nomad/security/dependabot/110

However, our dependency (a grandparent of the insecure underscore version) has not been updated in quite some time and appears to be unmaintained.

As such, I've given consideration to whether this feature is worth forking, pinning, or abandoning. Per zaach/jsonlint#120 a change has been merged to master in jsonlint, but no release on npm has been made. As such, I've opted to remove the feature for the same reasons other projects have done so: it doesn't give enough benefit to warrant hanging on to an un-updated dependency for marginal utility.

@philrenaud philrenaud self-assigned this May 3, 2024
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (once tests are green) This was a nice to have but if someone is really having trouble with it, the form-editor interface is still there instead of the JSON mode. And it's all ultimately validated server side.

@philrenaud
Copy link
Contributor Author

philrenaud commented May 3, 2024

LGTM! (once tests are green) This was a nice to have but if someone is really having trouble with it, the form-editor interface is still there instead of the JSON mode. And it's all ultimately validated server side.

Even better, it'll still run a JSON.parse() on user input on keypress, so the user will still get output like this before ever hitting the server:

image

(It just won't be the pretty code-mirror-gutter style lint errors that showed exact position, etc.)

Copy link

github-actions bot commented May 3, 2024

Ember Test Audit comparison

main 2f19e0e change
passes 1550 1550 0
failures 0 0 0
flaky 0 0 0
duration 10m 47s 484ms 10m 51s 067ms +03s 583ms

@philrenaud philrenaud added the backport/1.7.x backport to 1.7.x release line label May 3, 2024
@philrenaud philrenaud merged commit 890c2ce into main May 3, 2024
17 checks passed
@philrenaud philrenaud deleted the b-ui/remove-jsonlint-dep branch May 3, 2024 20:33
Copy link

github-actions bot commented Jan 9, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.7.x backport to 1.7.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants